Adding aws_ssm_maintenance_window_task, aws_ssm_parameter, aws_ssm_resource_data_sync to v1beta1 version - #429
Merged
Conversation
Contributor
Author
|
/test-examples="examples/ssm/parameter.yaml" |
3 tasks
sergenyalcin
approved these changes
Jan 9, 2023
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @mykolalosev LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adding 3 resources:
Fixes #353
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually:
aws_ssm_maintenance_window_task - requires an aws_instance id
aws_ssm_resource_data_sync - requires a deleting internal S3 Bucket objects
Manually & Uptest:
aws_ssm_parameter - https://github.com/upbound/provider-aws/actions/runs/3872644754