Moving networkfirewall(2), networkmanager(9) resources to v1beta1 version - #401
Conversation
c302ebb to
97469d9
Compare
|
/test-examples="examples/networkfirewall/firewallpolicy.yaml" |
|
/test-examples="examples/networkfirewall/rulegroup.yaml" |
|
/test-examples="examples/networkmanager/connection.yaml" |
|
/test-examples="examples/networkmanager/customergatewayassociation.yaml" |
|
/test-examples="examples/networkmanager/device.yaml" |
|
/test-examples="examples/networkmanager/globalnetwork.yaml" |
|
/test-examples="examples/networkmanager/link.yaml" |
|
/test-examples="examples/networkmanager/linkassociation.yaml" |
|
/test-examples="examples/networkmanager/site.yaml" |
|
/test-examples="examples/networkmanager/transitgatewayconnectpeerassociation.yaml" |
|
/test-examples="examples/networkmanager/transitgatewayregistration.yaml" |
sergenyalcin
left a comment
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @svscheg I left a few comments.
97469d9 to
144b9fc
Compare
add resources to networkfirewall(2), networkmanager(9) groups fix comments
144b9fc to
f9d7dd7
Compare
sergenyalcin
left a comment
sergenyalcin
left a comment
There was a problem hiding this comment.
Thanks @svscheg LGTM!
2 participants
Description of your changes
Moving
networkfirewall(2) resources to v1beta1 versionaws_networkfirewall_firewall_policyaws_networkfirewall_rule_groupMoving
networkmanager(9) resources to v1beta1 versionaws_networkmanager_connectionaws_networkmanager_customer_gateway_associationaws_networkmanager_deviceaws_networkmanager_global_networkaws_networkmanager_linkaws_networkmanager_link_associationaws_networkmanager_siteaws_networkmanager_transit_gateway_connect_peer_associationaws_networkmanager_transit_gateway_registrationFixes #378
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually
Uptests
Moving
networkfirewall(2) resources to v1beta1 versionaws_networkfirewall_firewall_policy- https://github.com/upbound/provider-aws/actions/runs/3795820981/jobs/6455322608aws_networkfirewall_rule_group- https://github.com/upbound/provider-aws/actions/runs/3795822120/jobs/6455324880Moving
networkmanager(9) resources to v1beta1 versionaws_networkmanager_connection- https://github.com/upbound/provider-aws/actions/runs/3795823066aws_networkmanager_customer_gateway_association- https://github.com/upbound/provider-aws/actions/runs/3795824069/jobs/6455328676aws_networkmanager_device- https://github.com/upbound/provider-aws/actions/runs/3795825206aws_networkmanager_global_network- https://github.com/upbound/provider-aws/actions/runs/3795826586/jobs/6455333504aws_networkmanager_link- https://github.com/upbound/provider-aws/actions/runs/3795827396/jobs/6455335504aws_networkmanager_link_association- https://github.com/upbound/provider-aws/actions/runs/3795835226/jobs/6455351312aws_networkmanager_site- https://github.com/upbound/provider-aws/actions/runs/3795836311/jobs/6455353058aws_networkmanager_transit_gateway_connect_peer_association- https://github.com/upbound/provider-aws/actions/runs/3795837039/jobs/6455354432aws_networkmanager_transit_gateway_registration- https://github.com/upbound/provider-aws/actions/runs/3795837743/jobs/6455355767