Use UPTEST_CLOUD_CREDENTIALS Github repo secret to enable cross-account resource uptesting - #231
Merged
Merged
Conversation
ulucinar
marked this pull request as draft
December 5, 2022 22:58
Collaborator
Author
|
/test-examples="examples/ec2/vpc.yaml" |
…ount resource uptesting Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
turkenh
approved these changes
Dec 6, 2022
Collaborator
Author
|
We sync'ed with @ezgidemirel who is on support rotation today and we decided to update the repo secret |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a change that would allow us to utilize a second IAM user for cross-account resource uptesting when the repo is properly configured with a second credentials environment variable.
A second
ProviderConfig.awsnamedpeeris provisioned in a different AWS account than thedefaultProviderConfig's account for cross-account testing.NOTE: This PR introduces a breaking change in the expected syntax for the Github repo secret
UPTEST_CLOUD_CREDENTIALS, and the corresponding env. variableUPTEST_CLOUD_CREDENTIALSwhen running uptest locally with the associated make targets. It now has the following syntax:So the value of the env. variable is expected to have the
DEFAULTkey to be used as the default set of credentials, and another optional key namedPEER.I have:
make reviewable testto ensure this PR is ready for review.UPTEST_CLOUD_CREDENTIALSUPTEST_CLOUD_CREDENTIALSsecret Github repo secret and add the second IAM user access credentials with thePEERkey.UPTEST_DATASOURCEUPTEST_DATASOURCEGithub repo secret so that it contains the ID of this second account.How has this code been tested
A second
ProviderConfig.awsnamedpeeris now available in the test runtime:Please also see: #235