Fix late init of SecurityGroupRule with self: true

[ytsarev]

Description of your changes

Add late init to self and source_security_group_id

Fixes #228

Signed-off-by: Yury Tsarev yury@upbound.io

I have:

• Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

k apply -f examples/ec2/securitygrouprule-self-true.yaml

k get managed
NAME                                        READY   SYNCED   EXTERNAL-NAME          AGE
securitygroup.ec2.aws.upbound.io/test-vpc   True    True     sg-00c2b14d55b3da787   10m

NAME                                READY   SYNCED   EXTERNAL-NAME           AGE
vpc.ec2.aws.upbound.io/sample-vpc   True    True     vpc-0f8da654a40cb68cb   10m

NAME                                                          READY   SYNCED   EXTERNAL-NAME       AGE
securitygrouprule.ec2.aws.upbound.io/test-vpc-securitygroup   True    True     sgrule-2687506433   10m

[ytsarev]

/test-examples="examples/ec2/securitygrouprule-self-true.yaml"

[ulucinar]

Hi @ytsarev,
Thank you very much for the quick fix.

As a future work, we can discuss how to utilize the schema.Schema.ConflictsWith to auto configure late initialization.

[ulucinar]

Should we also include cidr_blocks and ipv6_cidr_blocks together with the source_security_group_id?

I guess they don't get late-initialized since we have already tested the new configuration and hence not included here. Is this correct?

[ulucinar]

We had better add the meta.upbound.io/example-id: ec2/v1beta1/securitygrouprule annotations to the resource manifests.