Skip to content

fix: add missing reference to instance and cluster resources - #2156

Merged
erhancagirici merged 3 commits into
crossplane-contrib:mainfrom
fernandezcuesta:2155--add-missing-kms-selectors
Jul 29, 2026
Merged

fix: add missing reference to instance and cluster resources#2156
erhancagirici merged 3 commits into
crossplane-contrib:mainfrom
fernandezcuesta:2155--add-missing-kms-selectors

Conversation

@fernandezcuesta

@fernandezcuesta fernandezcuesta commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description of your changes

Fixes #2155

I have:

  • Read and followed Crossplane's contribution process.
  • Run make generate and committed the results (ideally in a separate commit).
  • Not made any manual changes to generated files, and verified this with make check-diff.

How has this code been tested

n/a

@fernandezcuesta
fernandezcuesta marked this pull request as ready for review July 24, 2026 12:17
@jonasz-lasut

jonasz-lasut commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster/v1beta2/cluster.yaml"

@jonasz-lasut

jonasz-lasut commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@fernandezcuesta could you please add a Secret resource to Cluster.rds and Instance.rds examples to make them uptestable?
examples/rds/cluster/v1beta3/instance.yaml && examples/rds/cluster/v1beta2/instance.yaml and their namespaced equivalents

Please also have a look at failing roundtrip tests, you need to backport the new Ref/Selector fields to older api versions

@jonasz-lasut

jonasz-lasut commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster/v1beta2/cluster.yaml"

erhancagirici
erhancagirici reviewed Jul 29, 2026
View reviewed changes
Comment thread examples/rds/cluster/v1beta2/cluster.yaml

---

apiVersion: rds.aws.upbound.io/v1beta1

@erhancagirici erhancagirici Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: uptest fails due to this unintentional removal of apiVersion

@fernandezcuesta @erhancagirici
fix: add missing reference to instance and cluster resources
878fe47 
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@fernandezcuesta @erhancagirici
chore: generate files
69c725a 
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@erhancagirici
erhancagirici force-pushed the 2155--add-missing-kms-selectors branch from 525443f to 6149bce Compare July 29, 2026 14:32
@erhancagirici

erhancagirici commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster/v1beta2/cluster.yaml"

@erhancagirici

erhancagirici commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster/v1beta3/instance.yaml"

@fernandezcuesta @erhancagirici
chore: backport and add secret examples
d9b065b 
Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
@erhancagirici
erhancagirici force-pushed the 2155--add-missing-kms-selectors branch from 6149bce to d9b065b Compare July 29, 2026 17:17
@erhancagirici

erhancagirici commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster/v1beta3/instance.yaml"

erhancagirici
erhancagirici approved these changes Jul 29, 2026
View reviewed changes

@erhancagirici erhancagirici left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fernandezcuesta, LGTM

@erhancagirici
erhancagirici merged commit 449eede into crossplane-contrib:main Jul 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erhancagirici erhancagirici erhancagirici approved these changes
@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner
@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner
@jastang jastang Awaiting requested review from jastang jastang is a code owner
@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner
@bobh66 bobh66 Awaiting requested review from bobh66 bobh66 is a code owner
@jonasz-lasut jonasz-lasut Awaiting requested review from jonasz-lasut jonasz-lasut is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cluster and Instance RDS resources missing performanceInsightsKmsKeyIdSelector

3 participants

@fernandezcuesta @jonasz-lasut @erhancagirici