Skip to content

feat: add new bedrockagentcore resources - #2143

Merged
erhancagirici merged 8 commits into
crossplane-contrib:mainfrom
erhancagirici:add-bedrockagentcore-resources-653
Jul 28, 2026
Merged

feat: add new bedrockagentcore resources#2143
erhancagirici merged 8 commits into
crossplane-contrib:mainfrom
erhancagirici:add-bedrockagentcore-resources-653

Conversation

@erhancagirici

@erhancagirici erhancagirici commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description of your changes

Depends on PR #2136 that bumps TF provider to v6.53.0

Adds new resources to bedrockagentcore group

  • Evaluator
  • Harness
  • OnlineEvaluationConfig
  • Policy
  • PolicyEngine
  • ResourcePolicy

I have:

  • Read and followed Crossplane's contribution process.
  • Run make generate and committed the results (ideally in a separate commit).
  • Not made any manual changes to generated files, and verified this with make check-diff.

How has this code been tested

Uptest-examples/bedrockagentcore/cluster/v1beta1/evaluator.yaml— Passed ✅
Uptest-examples/bedrockagentcore/cluster/v1beta1/policy.yaml — Passed (also includes PolicyEngine resource) ✅
Uptest-examples/bedrockagentcore/cluster/v1beta1/onlineevaluationconfig.yaml -- Pending
Uptest-examples/bedrockagentcore/cluster/v1beta1/harness.yaml -- Passed ✅

Uptest-examples/bedrockagentcore/cluster/v1beta1/resourcepolicy.yaml Not uptestable due to resourceArn parameter needs a valid AgentRuntime or Gateway ARN. Those resources have AWS-assigned identifiers, and Reference/Selector field is intentionally not added due to multiple valid GVKs. Manually tested ✅

Retest after rebase:
Uptest-examples/bedrockagentcore/cluster/v1beta1/evaluator.yaml — Passed
Uptest-examples/bedrockagentcore/cluster/v1beta1/harness.yaml — Passed
Uptest-examples/bedrockagentcore/cluster/v1beta1/onlineevaluationconfig.yaml — Passed
Uptest-examples/bedrockagentcore/cluster/v1beta1/policy.yaml — Passed

@erhancagirici

erhancagirici commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/policy.yaml"

@erhancagirici

erhancagirici commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/onlineevaluationconfig.yaml"

@erhancagirici

erhancagirici commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/evaluator.yaml"

@erhancagirici

erhancagirici commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/resourcepolicy.yaml"

@erhancagirici

erhancagirici commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/harness.yaml"

@erhancagirici
erhancagirici force-pushed the add-bedrockagentcore-resources-653 branch from 0df2ad1 to 332b81c Compare July 14, 2026 11:09
@erhancagirici
erhancagirici marked this pull request as ready for review July 14, 2026 11:13
@erhancagirici
erhancagirici force-pushed the add-bedrockagentcore-resources-653 branch from 332b81c to c542e58 Compare July 27, 2026 14:50
@erhancagirici

erhancagirici commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/evaluator.yaml"

@erhancagirici

erhancagirici commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/onlineevaluationconfig.yaml"

@erhancagirici

erhancagirici commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/policy.yaml"

@erhancagirici

erhancagirici commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/harness.yaml"

@erhancagirici
erhancagirici force-pushed the add-bedrockagentcore-resources-653 branch from c542e58 to 7adb1b6 Compare July 28, 2026 07:31
jonasz-lasut
jonasz-lasut reviewed Jul 28, 2026
View reviewed changes

@jonasz-lasut jonasz-lasut left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few small nits, other than that LGTM

Comment thread config/cluster/bedrockagentcore/config.go
Comment thread config/cluster/bedrockagentcore/config.go
Comment thread config/namespaced/bedrockagentcore/config.go
@erhancagirici
feat: configure new resources to bedrockagentcore group
b12363d 
- Evaluator
- Harness
- OnlineEvaluationConfig
- Policy
- PolicyEngine
- ResourcePolicy

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
generate: new bedrockagentcore resources
c441a81 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
config: register singleton list paths for new bedrockagentcore resources
133670c 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
generate: configure singleton lists bedrockagentcore
3f8f8e7 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
examples: add bedrockagentcore new resources
8fe96ad 
- Evaluator
- Harness
- OnlineEvaluationConfig
- Policy
- PolicyEngine
- ResourcePolicy

Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
bedrockagentcore: configure same-group reference fields
660f214 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
bedrockagentcore: configure cross-group reference fields
6aeed64 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
generate bedrockagentcore: cross-resource references
eb3fd72 
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
@erhancagirici
erhancagirici force-pushed the add-bedrockagentcore-resources-653 branch from 7adb1b6 to eb3fd72 Compare July 28, 2026 14:49
@erhancagirici

erhancagirici commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/harness.yaml"

@erhancagirici

erhancagirici commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/bedrockagentcore/cluster/v1beta1/policy.yaml"

@erhancagirici
erhancagirici merged commit ce910f3 into crossplane-contrib:main Jul 28, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonasz-lasut jonasz-lasut jonasz-lasut approved these changes
@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner
@turkenf turkenf Awaiting requested review from turkenf turkenf is a code owner
@jastang jastang Awaiting requested review from jastang jastang is a code owner
@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner
@bobh66 bobh66 Awaiting requested review from bobh66 bobh66 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erhancagirici @jonasz-lasut