Add cloudwatchlogs.AccountPolicy resource - #2127
Merged
sergenyalcin merged 3 commits intoJun 26, 2026
Merged
Conversation
sergenyalcin
requested review from
bobh66,
erhancagirici,
jastang,
turkenf and
ulucinar
as code owners
June 22, 2026 10:55
ulucinar
reviewed
Jun 24, 2026
ulucinar
left a comment
ulucinar
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @sergenyalcin for adding the AccountPolicy.cloudwatchlogs resource. I think I've observed an issue with the external-name configuration. Could you please also check?
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
add-cloudwatchlogs-account-policy-resource
branch
from
June 25, 2026 10:48
8429aa3 to
44eedd7
Compare
Collaborator
Author
|
/test-examples="examples/cloudwatchlogs/cluster/v1beta1/accountpolicy.yaml" |
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Collaborator
Author
|
/test-examples="examples/cloudwatchlogs/cluster/v1beta1/accountpolicy.yaml" |
ulucinar
approved these changes
Jun 26, 2026
ulucinar
left a comment
ulucinar
left a comment
Collaborator
There was a problem hiding this comment.
Thank you @sergenyalcin, lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds
cloudwatchlogs.AccountPolicyresource.I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Tested locally for Create, Import, Delete paths.
Uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/28167209674