Moving appconfig appflow appintegrations - #210
Conversation
769e3e9 to
dcb9dee
Compare
|
/test-examples="examples/appconfig/deployment.yaml" |
|
/test-examples="examples/appflow/flow.yaml" |
|
/test-examples="examples/appconfig/application.yaml" |
|
/test-examples="examples/appconfig/configurationprofile.yaml" |
|
/test-examples="examples/appconfig/deploymentstrategy.yaml" |
|
/test-examples="examples/appconfig/environment.yaml" |
|
/test-examples="examples/appconfig/hostedconfigurationversion.yaml" |
|
/test-examples="examples/appintegrations/eventintegration.yaml" |
|
/test-examples="examples/appconfig/environment.yaml" |
c9b863a to
c5e7460
Compare
|
/test-examples="examples/appflow/flow.yaml" |
|
/test-examples="examples/appconfig/deployment.yaml" |
svscheg
changed the title
| // appflow | ||
| // | ||
| // AppFlow flows can be imported using the arn | ||
| "aws_appflow_flow": config.IdentifierFromProvider, |
There was a problem hiding this comment.
As above:
| "aws_appflow_flow": config.IdentifierFromProvider, | |
| // arn:aws:appflow:us-west-2:123456789012:flow/example-flow | |
| "aws_appflow_flow": config.TemplatedStringAsIdentifier("name", "arn:aws:appflow:{{ .parameters.region }}:{{ .client_metadata.account_id }}:flow/{{ .external_name }}"), |
| // Amazon AppIntegrations Event Integrations can be imported using the name | ||
| "aws_appintegrations_event_integration": config.NameAsIdentifier, | ||
| // AppFlow connector profiles can be imported using the arn | ||
| "aws_appflow_connector_profile": config.IdentifierFromProvider, |
There was a problem hiding this comment.
Why do we introduce a new untested configuration in this PR? This does not exist in config/externalname.go.
| "aws_alb_target_group$", // identical with aws_lb_target_group. | ||
| "aws_alb_target_group_attachment$", // identical with aws_lb_target_group_attachment. | ||
| "aws_iot_authorizer$", // failure with unknown reason. | ||
| "aws_appflow_connector_profile$", // failure with unknown reason. |
There was a problem hiding this comment.
I think we still don't generate this.
There was a problem hiding this comment.
back "aws_appflow_connector_profile$", // failure with unknown reason. to config/provider.go
3744088 to
e3c3a10
Compare
e3c3a10 to
ad8ca3d
Compare
|
/test-examples="examples/appflow/flow.yaml" |
|
/test-examples="examples/appintegrations/eventintegration.yaml" |
|
/test-examples="examples/appflow/flow.yaml" |
|
/test-examples="examples/appintegrations/eventintegration.yaml" |
3 participants
Description of your changes
Moving 6 resources in the
appconfiggroup:aws_appconfig_applicationaws_appconfig_configuration_profileaws_appconfig_deploymentaws_appconfig_deployment_strategyaws_appconfig_environmentaws_appconfig_hosted_configuration_versionMoving 1 resources in the
appflowgroup:aws_appflow_flowMoving 1 resource in the
appintegrationsgroup:aws_appintegrations_event_integrationFixes #23
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually
aws_appconfig_deploymentUptest
Moving 6 resources in the
appconfiggroup:aws_appconfig_application- https://github.com/upbound/provider-aws/actions/runs/3572128766/jobs/6004666277aws_appconfig_configuration_profile- https://github.com/upbound/provider-aws/actions/runs/3572129897/jobs/6004668855aws_appconfig_deployment_strategy- https://github.com/upbound/provider-aws/actions/runs/3572131293/jobs/6004671614aws_appconfig_environment- https://github.com/upbound/provider-aws/actions/runs/3572268059/jobs/6004964311aws_appconfig_hosted_configuration_version- https://github.com/upbound/provider-aws/actions/runs/3572143803/jobs/6004699243Moving 1 resources in the
appflowgroup:aws_appflow_flow- https://github.com/upbound/provider-aws/actions/runs/3631956827/jobs/6127235702Moving 1 resource in the
appintegrationsgroup:aws_appintegrations_event_integration- https://github.com/upbound/provider-aws/actions/runs/3631963079/jobs/6127250242