Skip to content

Add additional connection details for RDS Cluster - #203

Merged
ulucinar merged 1 commit into
crossplane-contrib:mainfrom
loafoe:feature/rds-additional-connection-details
Dec 6, 2022
Merged

Add additional connection details for RDS Cluster#203
ulucinar merged 1 commit into
crossplane-contrib:mainfrom
loafoe:feature/rds-additional-connection-details

Conversation

@loafoe

@loafoe loafoe commented Nov 25, 2022

Copy link
Copy Markdown
Contributor

Description of your changes

Add additional connection details:

  • endpoint
  • reader_endpoint

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Test by building and deploying changes to an AWS EKS cluster and provisioning an RDS Aurora serverless v2 instance

- endpoint
- reader_endpoint
@Upbound-CLA

Upbound-CLA commented Nov 25, 2022

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@loafoe loafoe changed the title Add additional connection details for RDS Add additional connection details for RDS Cluster Nov 25, 2022
@ulucinar

ulucinar commented Dec 1, 2022

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster.yaml"

1 similar comment
@ulucinar

ulucinar commented Dec 6, 2022

Copy link
Copy Markdown
Collaborator

/test-examples="examples/rds/cluster.yaml"

@ulucinar ulucinar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @loafoe, lgtm.

@ulucinar
ulucinar merged commit 72ba604 into crossplane-contrib:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants