Add aws_oam_sink resource - #1947
Merged
Merged
Conversation
Signed-off-by: Eylül Geyik <eylulgyk@gmail.com>
ey22
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
January 9, 2026 15:40
Collaborator
|
/test-examples="examples/oam/cluster/v1beta1/sink.yaml" |
Contributor
Author
|
Hi @jeanduplessis, thanks for running the uptest. Since the test was successful, I wanted to reach out to see if we can proceed to the next steps, if it's appropriate. Thanks! |
jeanduplessis
approved these changes
Jan 20, 2026
jeanduplessis
left a comment
jeanduplessis
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thanks @ey22
turkenf
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1940
This PR adds aws_oam_sink resource.
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Tested locally via Uptest: