Add aws_vpc_endpoint_connection_accepter resource - #1935
Merged
erhancagirici merged 2 commits intoDec 15, 2025
Merged
Conversation
Signed-off-by: Eylül Geyik <eylulgyk@gmail.com>
ey22
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
December 12, 2025 12:43
Signed-off-by: Eylül Geyik <eylulgyk@gmail.com>
ey22
force-pushed
the
add-vpc-endpoint-connection-accepter
branch
from
December 12, 2025 12:45
8df970f to
8af016f
Compare
Collaborator
|
/test-examples="examples/ec2/cluster/v1beta1/vpcendpointconnectionaccepter.yaml" |
erhancagirici
approved these changes
Dec 15, 2025
erhancagirici
left a comment
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
@ey22 many thanks for the contribution 🎉 I triggered the Uptest and it is green too. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1914
This PR adds
aws_vpc_endpoint_connection_accepterresource.I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Uptest: Uptest-examples/ec2/cluster/v1beta1/vpcendpointconnectionaccepter.yaml
Tested manually: