Consume latest mq.User update loop fix - #1934
Merged
sergenyalcin merged 2 commits intoDec 5, 2025
Merged
Conversation
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
requested review from
erhancagirici,
jastang,
turkenf and
ulucinar
as code owners
December 3, 2025 17:02
Collaborator
Author
|
/test-examples="examples/mq/cluster/v1alpha1/user-with-consoleAccess.yaml" |
sergenyalcin
marked this pull request as draft
December 3, 2025 18:56
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
bump-tf-fork-version
branch
from
December 4, 2025 21:09
3eacfec to
857443c
Compare
Collaborator
Author
|
/test-examples="examples/mq/cluster/v1alpha1/user-with-consoleAccess.yaml" |
sergenyalcin
marked this pull request as ready for review
December 4, 2025 22:13
erhancagirici
approved these changes
Dec 5, 2025
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
@sergenyalcin thanks for the effort on fixing this 🚀 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
consoleAccessusage.I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Uptest -> https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/19944394268
Tested locally via uptest: