Skip to content

feat(rds): add standard connection secret keys for crossplane-runtime compatibility - #1930

Open
Keralin wants to merge 5 commits into
crossplane-contrib:mainfrom
Keralin:fix/rds-cluster-standard-connection-keys
Open

feat(rds): add standard connection secret keys for crossplane-runtime compatibility#1930
Keralin wants to merge 5 commits into
crossplane-contrib:mainfrom
Keralin:fix/rds-cluster-standard-connection-keys

Conversation

@Keralin

@Keralin Keralin commented Nov 28, 2025

Copy link
Copy Markdown

Summary

Add username and password keys to aws_rds_cluster connection secrets to enable compatibility with provider-sql and other consumers that expect standard crossplane-runtime connection secret keys.

Changes:

  • config/cluster/rds: Add username (alias of master_username) and password (from master_password) to connection secrets
  • config/namespaced/rds: Same changes for namespaced variant

Existing keys (master_username) are preserved for backwards compatibility.

Connection Secret Output (after this fix)

data:
  endpoint: xxxxxx
  reader_endpoint: xxxxxx
  master_username: xxxxxx  # Preserved for backwards compatibility
  username: xxxxxx         # NEW - Standard crossplane-runtime key
  port: xxxxxx
  password: xxxxxx         # NEW - Standard crossplane-runtime key

Fixes #1189

Related issues:

@Keralin
Keralin force-pushed the fix/rds-cluster-standard-connection-keys branch 2 times, most recently from 9bbfd3a to a147c9b Compare November 28, 2025 08:30
… compatibility

Add 'username' and 'password' keys to aws_rds_cluster connection secrets
to enable compatibility with provider-sql and other consumers that expect
standard crossplane-runtime connection secret keys.

Existing keys (master_username, master_password) are preserved for
backwards compatibility.

Fixes: crossplane-contrib#1189

Signed-off-by: Francisco Barón <baronizquierdo@gmail.com>
@github-actions

Copy link
Copy Markdown

This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as stale. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

@github-actions github-actions Bot added the stale label Mar 11, 2026
@Keralin

Keralin commented Mar 11, 2026

Copy link
Copy Markdown
Author

/fresh

@github-actions github-actions Bot removed the stale label Mar 12, 2026
@Upbound-CLA

Upbound-CLA commented Apr 30, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow writeConnectionSecretToRef to be compatible with SQL community provider

2 participants