update Go module to contain /v2 - #1928
Merged
Merged
Conversation
1 task
Collaborator
Author
|
/test-examples="examples/ec2/cluster/v1beta1/vpc.yaml" |
Collaborator
Author
|
/test-examples="examples/s3/cluster/v1beta2/bucket.yaml" |
erhancagirici
marked this pull request as ready for review
November 26, 2025 11:17
erhancagirici
requested review from
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
November 26, 2025 11:17
Collaborator
Author
|
/test-examples="examples/ec2/namespaced/v1beta1/vpc.yaml" |
sergenyalcin
approved these changes
Dec 1, 2025
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @erhancagirici LGTM!
erhancagirici
force-pushed
the
v2-module
branch
from
December 1, 2025 12:17
a55f964 to
e93fb64
Compare
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
erhancagirici
force-pushed
the
v2-module
branch
from
December 1, 2025 13:10
e93fb64 to
56a2ae6
Compare
Collaborator
Author
|
/test-examples="examples/ec2/cluster/v1beta1/vpc.yaml" |
Collaborator
Author
|
/test-examples="examples/s3/cluster/v1beta2/bucket.yaml" |
Collaborator
Author
|
Note: The local-deploy job is failing due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR allows importing the provider as a go module when requiring with
v2.x.xsemantic version tags.This was only possible with workaround using
go mod -replaceand pseudo-versions.or
go.modto contain/v2.gofiles with new module path referencePROJECT_REPOto contain/v2inMakefile, because it also sets the module path prefixes in make targets, used for package discovery for unit tests etc.Fixes #1865
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
CI and Uptest
Uptest-examples/ec2/cluster/v1beta1/vpc.yaml
Uptest-examples/s3/cluster/v1beta2/bucket.yaml
Uptest-examples/ec2/namespaced/v1beta1/vpc.yaml