Add Support for Scraper resource in amp provider - #1918
Conversation
|
/test-examples="examples/amp/cluster/v1beta1/scraper.yaml" |
|
@jeanduplessis looks like the e2e failed because the scraper was in a |
erhancagirici
left a comment
There was a problem hiding this comment.
@nujragan93 thanks for the PR! Looks good overall, left some minor change requests.
I checked this and was able to reproduce the issue. This looks like to be an issue at upjet causing an superfluous diff, which I am investigating with a potential fix. I'll further update here. For that no action is needed from your side.
cd39765 to
50c4169
Compare
|
@erhancagirici Thanks for your review, Added amp config to namespaced type. |
3b5f023 to
4f4b1d5
Compare
|
/test-examples="examples/amp/cluster/v1beta1/scraper.yaml" |
|
After consuming the fix at Upjet, the Uptest run passed. Linter is complaining about some deprecated field usage (unrelated to this PR) after upjet bump, so opened a dedicated PR #1931 to handle the upjet bump. Will rebase this PR after that one is merged. |
Signed-off-by: Nagarjun Krishnan <nkrishnan@ancestry.com>
Signed-off-by: Nagarjun Krishnan <nkrishnan@ancestry.com>
Signed-off-by: Nagarjun Krishnan <nkrishnan@ancestry.com>
15978c6 to
85eeeaa
Compare
|
/test-examples="examples/amp/cluster/v1beta1/scraper.yaml" |
erhancagirici
left a comment
There was a problem hiding this comment.
Thanks @nujragan93 for the contribution 🙌 ! I've rebased the PR to latest main with the fix included, and now it passes the tests. LGTM!
Description of your changes
Add support for AMP Prometheus Scraper resource
Fixes #
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Manual Testing Running AMP Provider with crossplane
Tested creating, observing and deletion of the resource
Tested referencing workspace object from scraper resource