fix: use 12-digit fallback account ID - #1915
Merged
erhancagirici merged 1 commit intoDec 17, 2025
Merged
Conversation
viren-nadkarni
force-pushed
the
fix-fallback-account-id
branch
from
November 13, 2025 10:32
b7d0837 to
37e634f
Compare
viren-nadkarni
marked this pull request as ready for review
November 13, 2025 10:32
viren-nadkarni
requested review from
erhancagirici,
jastang,
sergenyalcin,
turkenf and
ulucinar
as code owners
November 13, 2025 10:32
erhancagirici
force-pushed
the
fix-fallback-account-id
branch
from
December 5, 2025 06:58
37e634f to
fc0b73a
Compare
Signed-off-by: Viren Nadkarni <viren.nadkarni@gmail.com>
erhancagirici
force-pushed
the
fix-fallback-account-id
branch
from
December 17, 2025 10:35
fc0b73a to
cb1a29f
Compare
Collaborator
|
/test-examples="examples/ec2/cluster/v1beta1/vpc.yaml" |
erhancagirici
approved these changes
Dec 17, 2025
erhancagirici
left a comment
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @viren-nadkarni for fixing this! LGTM
erhancagirici
merged commit Dec 17, 2025
b69b4c8
into
crossplane-contrib:main
15 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR makes the provider AWS client use a valid fallback account ID that has 12 digits.
AWS account IDs always have 12 digits. At the moment, the provider uses a 9 digit account ID which has a different meaning in LocalStack configuration.
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested