Skip to content

Add support for dsql(2) resources - #1900

Merged
turkenf merged 5 commits into
crossplane-contrib:mainfrom
turkenf:dsql-support
Nov 5, 2025
Merged

Add support for dsql(2) resources#1900
turkenf merged 5 commits into
crossplane-contrib:mainfrom
turkenf:dsql-support

Conversation

@turkenf

@turkenf turkenf commented Nov 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description of your changes

Add support for dsql(2) resources

I have:

How has this code been tested

Manually:

NAME                                             SYNCED   READY   EXTERNAL-NAME                AGE
clusterpeering.dsql.aws.m.upbound.io/example-1   True     True    pvtjjwrzgrnnam27xcozpv55cq   9m59s
clusterpeering.dsql.aws.m.upbound.io/example-2   True     True    kftjjwry6hzqzi7i6bi3ni6d6a   9m59s

NAME                                      SYNCED   READY   EXTERNAL-NAME                AGE
cluster.dsql.aws.m.upbound.io/example-1   True     True    pvtjjwrzgrnnam27xcozpv55cq   15m
cluster.dsql.aws.m.upbound.io/example-2   True     True    kftjjwry6hzqzi7i6bi3ni6d6a   15m

@turkenf

turkenf commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/cluster.yaml"

1 similar comment
@turkenf

turkenf commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/cluster.yaml"

This was referenced Nov 3, 2025
Merged
Merged
@turkenf

turkenf commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/clusterpeering.yaml"

turkenf and others added 3 commits November 5, 2025 00:22
@turkenf
Add support for dsql(2) resources
ce92d00 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf
Add dsql Cluster peering resource
60e392b 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@ulucinar @turkenf
Fix ClusterPeering.cluster config
2e1d9e9 
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
@turkenf

turkenf commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/clusterpeering.yaml"

@turkenf

turkenf commented Nov 4, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/cluster.yaml"

1 similar comment
@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/cluster.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/clusterpeering.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/cluster.yaml"

@turkenf
Add config file for namespaced and update namespaced example
24f0a64 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/clusterpeering.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/cluster.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/clusterpeering.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/s3/cluster/v1beta1/bucket.yaml"

@jeanduplessis jeanduplessis mentioned this pull request Nov 5, 2025
Closed
@turkenf
Bump upjet to the commit e6784cf618e18d813728eb9b047ab4a063b55ec3
e8996e5 
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/s3/cluster/v1beta1/bucket.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/namespaced/v1beta1/clusterpeering.yaml"

@turkenf

turkenf commented Nov 5, 2025

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/dsql/cluster/v1beta1/cluster.yaml"

@turkenf
turkenf marked this pull request as ready for review November 5, 2025 14:42
ulucinar
ulucinar approved these changes Nov 5, 2025
View reviewed changes

@ulucinar ulucinar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

@turkenf
turkenf merged commit 3c200e7 into crossplane-contrib:main Nov 5, 2025
11 checks passed
@GanyuanTan

GanyuanTan commented Nov 6, 2025

Copy link
Copy Markdown

Thanks @turkenf, I was working on #1904, good to have this be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ulucinar ulucinar ulucinar approved these changes
@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner
@jastang jastang Awaiting requested review from jastang jastang is a code owner
@erhancagirici erhancagirici Awaiting requested review from erhancagirici erhancagirici is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@turkenf @GanyuanTan @ulucinar