fix: namespaced MR aware PasswordGenerator configuration - #1890
Merged
sergenyalcin merged 1 commit intoOct 23, 2025
Conversation
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
Collaborator
Author
|
/test-examples="examples/docdb/namespaced/v1beta1/cluster.yaml" |
sergenyalcin
marked this pull request as ready for review
October 22, 2025 17:28
erhancagirici
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR fixes
PasswordGeneratorinitializer function by making it namespaced MR aware. It should have operated on a namespaced MR and a LocalSecretRef. Unit tests are updated.Fixes #1855
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested