Fix converted singleton lists in the generated example manifests - #1888
Merged
ulucinar merged 1 commit intoOct 16, 2025
Merged
Conversation
ulucinar
requested review from
jastang,
sergenyalcin and
turkenf
as code owners
October 16, 2025 10:31
3 tasks
ulucinar
force-pushed
the
convert-generated-examples
branch
2 times, most recently
from
October 16, 2025 13:51
a26710d to
4baff18
Compare
- We now post process the generated example manifests for the latest versions of the resources by applying the API converters and adding license headers. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
convert-generated-examples
branch
from
October 16, 2025 14:05
4baff18 to
1d62fb4
Compare
sergenyalcin
approved these changes
Oct 16, 2025
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PRs: https://github.com/crossplane/upjet/pull/538/files
This PR fixes the converted singleton lists in the generated example manifests. We now post process the generated example manifests for the latest versions of the resources by applying the API converters and adding license headers.
This PR also adds a license file,
hack/boilerplate.yaml.txt, to be used for the generated example manifests.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested