Use a wildcard for Make variable SUBPACKAGES to represent all family packages - #1868
Merged
Merged
Conversation
…amily members but "monolith" are implied. - Now we can run a `make SUBPACKAGES='*' ...` to run the target on all family members, excluding the "monolith", which is not a family. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
requested review from
jastang,
mbbush,
sergenyalcin and
turkenf
as code owners
September 23, 2025 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
When the make variable "SUBPACKAGES" is set to the literal "*", all family members but the "monolith" are implied. Now we can run a
make SUBPACKAGES='*' ...to run the target on all family members, excluding the "monolith", which is not a family.We could as well use a sentinel value other than
'*'(likeall) not to deal with globbing but I preferred to use*because:*would be a good, conventional sentinel value for representing all family members.monolithis automatically excluded from the list of family members and the config package is included.I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Manually tested a target that depends on the make variable
SUBPACKAGESusingmake SUBPACKAGES='*' ....