Update custom diff for partition_index in glue CatalogTable - #1848
Merged
Conversation
Collaborator
Author
|
/test-examples="examples/cluster/glue/v1beta1/catalogtable-with-pi.yaml" |
Collaborator
Author
|
/test-examples="examples/cluster/glue/v1beta1/catalogtable.yaml" |
1 similar comment
Collaborator
Author
|
/test-examples="examples/cluster/glue/v1beta1/catalogtable.yaml" |
erhancagirici
left a comment
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
@turkenf thanks for the PR, LGTM! Just two things regarding examples:
- the
examplesdirectory structure is rearranged, so this PR needs a rebase with the new paths. - the changes in the examples should be duplicated also to namespaced examples.
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Collaborator
Author
|
/test-examples="examples/glue/cluster/v1beta1/catalogtable-with-pi.yaml" |
erhancagirici
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Update custom diff for partition_index in glue CatalogTable
Fixes: #1340
I have:
make generateand committed the results (ideally in a separate commit).How has this code been tested
Uptest-examples/cluster/glue/v1beta1/catalogtable.yaml
Uptest-examples/cluster/glue/v1beta1/catalogtable-with-pi.yaml