Fix Elasticache ReplicationGroup conversion from v1beta2 to v1beta1 - #1847
Merged
erhancagirici merged 2 commits intoAug 29, 2025
Merged
Conversation
walt-grata
requested review from
jastang,
mbbush,
sergenyalcin and
turkenf
as code owners
August 25, 2025 19:39
Collaborator
|
@walt-grata thanks for the fix! Looks like your commit is not signed-off and failing the DCO check. Could you rebase, sign-off and push again? |
walt-grata
force-pushed
the
fix-conversion-redis
branch
from
August 25, 2025 21:23
4f45159 to
dcd6d2a
Compare
Contributor
Author
|
@erhancagirici updated |
walt-grata
force-pushed
the
fix-conversion-redis
branch
from
August 26, 2025 13:35
dcd6d2a to
a29fb48
Compare
walt-grata
changed the title
walt-grata
force-pushed
the
fix-conversion-redis
branch
from
August 27, 2025 22:32
790fcd1 to
581d7e9
Compare
Signed-off-by: Walt Grata <walt.grata@upbound.io>
erhancagirici
force-pushed
the
fix-conversion-redis
branch
from
August 28, 2025 11:33
581d7e9 to
d6accb2
Compare
Signed-off-by: Walt Grata <walt.grata@upbound.io>
walt-grata
force-pushed
the
fix-conversion-redis
branch
from
August 28, 2025 14:41
21cec23 to
b8e6424
Compare
erhancagirici
approved these changes
Aug 29, 2025
erhancagirici
left a comment
erhancagirici
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks for the fix! LGTM
sergenyalcin
approved these changes
Aug 29, 2025
erhancagirici
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This fixes a bug in the conversion webhook for
ClusterModewhere it failed to convert from v1beta2 to v1beta1. This fixes the error and adds some tests to ensure the fix is correct.Fixes #
I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested