add basic plumbing for provider startup checks - #1818
Merged
Conversation
Signed-off-by: Jason Tang <jason@upbound.io>
jastang
marked this pull request as draft
July 15, 2025 20:54
jastang
marked this pull request as ready for review
July 16, 2025 15:04
sergenyalcin
approved these changes
Jul 17, 2025
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @jastang LGTM!
Signed-off-by: Jason Tang <jason@upbound.io>
ctenberge-oneid
pushed a commit
to ctenberge-oneid/provider-upjet-aws
that referenced
this pull request
Jul 18, 2025
* add basic plumbing for provider startup checks Signed-off-by: Jason Tang <jason@upbound.io> * Add SPDX license header Signed-off-by: Jason Tang <jason@upbound.io> --------- Signed-off-by: Jason Tang <jason@upbound.io>
This was referenced Jul 23, 2025
sergenyalcin
pushed a commit
to sergenyalcin/official-provider-aws
that referenced
this pull request
Dec 4, 2025
* add basic plumbing for provider startup checks Signed-off-by: Jason Tang <jason@upbound.io> * Add SPDX license header Signed-off-by: Jason Tang <jason@upbound.io> --------- Signed-off-by: Jason Tang <jason@upbound.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR proposes a simple approach to enable custom startup checks on the provider by updating the main.go.tmpl. As a concrete example, users may run their workloads in highly regulated environments where the provider should not start if the environment is not properly configured.
This implements the default path, which is a no-op. It uses a combination of an
init()hook and go build tags to:A (simplified) example of an alternative implementation is building images with a compliance check (e.g. running in a FIPS-enabled host). What that would look like is:
internal/bootcheck/fips.goGO_TAGS=fipsto produce images targeting that specific compliance check.I have:
make generateand committed the results (ideally in a separate commit).make check-diff.How has this code been tested
Locally building and installing the xpkg.