RDS: Add support for InstanceState

[ytsarev]

Description of your changes

Add support for https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_instance_state

I have:

• Read and followed Crossplane's contribution process.
• Run make generate and committed the results (ideally in a separate commit).
• Not made any manual changes to generated files, and verified this with make check-diff.

How has this code been tested

k get -f examples/rds/v1beta1/instancestate.yaml
NAME                                                     SYNCED   READY   EXTERNAL-NAME           AGE
instancestate.rds.aws.upbound.io/example-instancestate   True     True    example-instancestate   21m

NAME                                                READY   SYNCED   EXTERNAL-NAME                   AGE
instance.rds.aws.upbound.io/example-instancestate   True    True     db-VZVRXGW5NIADDI3D3VF4MOBHVE   21m

Change state: available to state: stopped in InstanceState spec

apiVersion: rds.aws.upbound.io/v1beta1
kind: InstanceState
metadata:
  annotations:
    meta.upbound.io/example-id: rds/v1beta1/instancestate
  labels:
    testing.upbound.io/example-name: instancestate
  name: example-instancestate
spec:
  forProvider:
    identifierSelector:
      matchLabels:
        testing.upbound.io/example-name: instancestate
    region: us-west-1
    state: stopped <--- HERE

Reapply manifest, observe that the target RDS instance is getting stopped in the console, first Stopping... then eventually getting to Stopped Temporarily

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

[turkenf]

The import section in the Terraform document seemed a bit contradictory to me. The document gives two different formats for importing this resource.

1. db-L72FUFBZX2RRXT3HOJSIUQVOKE
2. rds_instance_state-instanceId-12345678

The second format and the one we are using here seems a bit suspicious to me. We cannot observe the import test because the uptest is currently failing due to a connection error. Did you perform a manual import test?

[turkenf]

And from what I understand from the source code, the correct format seems to be the first one(db-...), can you please try the following configuration. And it would be great to verify this with an import test :)

Suggested change

	"aws_rds_instance_state": config.TemplatedStringAsIdentifier("", "rds_instance_state-{{ .parameters.identifier }}"),
	"aws_rds_instance_state": config.TemplatedStringAsIdentifier("", "{{ .parameters.identifier }}"),

[ytsarev]

@turkenf I updated the simplified configuration according to your suggestion.

Observations:

• Everything works in general according to the initial PR description. I still see example-instancestate 'internal' name as external name of instance state for some reason

k get -f examples/rds/v1beta1/instancestate.yaml
NAME                                                     SYNCED   READY   EXTERNAL-NAME           AGE
instancestate.rds.aws.upbound.io/example-instancestate   True     True    example-instancestate   15m

NAME                                                READY   SYNCED   EXTERNAL-NAME                   AGE
instance.rds.aws.upbound.io/example-instancestate   True    True     db-5XBUBIXX5VXQQTSMYIJTCTYRGQ   15m

• Import test. Import works even when crossplane.io/external-name is whatever . The resolved forProvider.identifier takes presedence and drives the import.

k get -f examples/rds/v1beta1/instancestate.yaml
NAME                                                     SYNCED   READY   EXTERNAL-NAME   AGE
instancestate.rds.aws.upbound.io/example-instancestate   True     True    whatever        5m7s

NAME                                                READY   SYNCED   EXTERNAL-NAME                   AGE
instance.rds.aws.upbound.io/example-instancestate   True    True     db-5XBUBIXX5VXQQTSMYIJTCTYRGQ   26m

So from the functional standpoint everything is working, the default extetnal-name propagation is slightly confusing

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

[turkenf]

/test-examples="examples/rds/v1beta1/instancestate.yaml"

https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/15615730328