Use ARN extractor for Cloudwatch log group kms_key_id reference - #1675
Merged
turkenf merged 4 commits intoFeb 6, 2025
Conversation
Signed-off-by: Finlay Sawyer <18363677+finlaysawyer@users.noreply.github.com>
Contributor
Author
|
/test-examples="examples/cloudwatchlogs/v1beta1/group-with-kms.yaml" |
finlaysawyer
marked this pull request as ready for review
February 6, 2025 19:39
finlaysawyer
requested review from
mbbush,
sergenyalcin,
turkenf and
ulucinar
as code owners
February 6, 2025 19:39
Collaborator
|
/test-examples="examples/cloudwatchlogs/v1beta1/group-with-kms.yaml" |
Signed-off-by: Finlay Sawyer <18363677+finlaysawyer@users.noreply.github.com>
Collaborator
|
/test-examples="examples/cloudwatchlogs/v1beta1/group-with-kms.yaml" |
Signed-off-by: Finlay Sawyer <18363677+finlaysawyer@users.noreply.github.com>
Contributor
Author
|
Forgot the key policy, that should fix up the e2e |
Collaborator
|
/test-examples="examples/cloudwatchlogs/v1beta1/group-with-kms.yaml" |
turkenf
approved these changes
Feb 6, 2025
turkenf
left a comment
turkenf
left a comment
Collaborator
There was a problem hiding this comment.
Hey @finlaysawyer,
Congratulations on your first contribution! 🎉 Thanks for this fix—it’s a great improvement. LGTM! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Currently, when specifying a reference to an AWS KMS Key in a Cloudwatch logs
Group, it tries to use the KMS Key ID which does not work. It should use the ARN of the resource.Despite the confusing parameter name, the TF provider docs do state this here:
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
I have added an additional E2E test to cover this behaviour, let me know if this is suitable.
https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/13188245301