Issue 8 - #161
Conversation
|
/test-examples="examples/cur/reportdefinition.yaml,examples/dataexchange/dataset.yaml,examples/dataexchange/revision.yaml,examples/datapipeline/pipeline.yaml,examples/configservice/configurationaggregator.yaml,examples/configservice/remediationconfiguration.yaml" |
|
/test-examples="examples/cur/reportdefinition.yaml,examples/dataexchange/dataset.yaml,examples/dataexchange/revision.yaml,examples/datapipeline/pipeline.yaml,examples/configservice/configurationaggregator.yaml,examples/configservice/remediationconfiguration.yaml" |
| matchLabels: | ||
| testing.upbound.io/example-name: example | ||
| region: us-west-1 | ||
|
|
There was a problem hiding this comment.
please remove empty lines.
There was a problem hiding this comment.
still seeing empty lines, did you forget to commit/push ?
|
@mykolalosev, thanks for the PR. |
|
/test-examples="examples/cur/reportdefinition.yaml" |
|
/test-examples="examples/dataexchange/dataset.yaml" |
|
/test-examples="examples/cur/reportdefinition.yaml" |
|
/test-examples="examples/dataexchange/dataset.yaml" |
|
/test-examples="examples/dataexchange/revision.yaml" |
|
|
|
/test-examples="examples/datapipeline/pipeline.yaml" |
|
/test-examples="examples/configservice/configurationaggregator.yaml" |
|
/test-examples="examples/configservice/remediationconfiguration.yaml" |
|
/test-examples="examples/cur/reportdefinition.yaml" |
| "s3:GetBucketAcl", | ||
| "s3:GetBucketPolicy" | ||
| ], | ||
| "Resource":"arn:aws:s3:::test-definition-bucket-*", |
There was a problem hiding this comment.
Should we revert wildcards here (and a couple of more below) as well?
There was a problem hiding this comment.
It's up to you. Unlike the BucketPolicy, in the Policy wildcards work well.
| matchLabels: | ||
| testing.upbound.io/example-name: example | ||
| region: us-west-1 | ||
|
|
There was a problem hiding this comment.
still seeing empty lines, did you forget to commit/push ?
turkenh
left a comment
turkenh
left a comment
There was a problem hiding this comment.
Thanks @mykolalosev, looking great 👍
3 participants
Description of your changes
Adds the following resources:
aws_cur_report_definitionaws_dataexchange_data_setaws_dataexchange_revisionaws_datapipeline_pipelineFixes #8
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually and Uptest:
cur_report_definition: https://github.com/upbound/provider-aws/actions/runs/3548136037
aws_dataexchange_data_set: https://github.com/upbound/provider-aws/actions/runs/3532575085
aws_dataexchange_revision: https://github.com/upbound/provider-aws/actions/runs/3532920082
aws_datapipeline_pipeline: https://github.com/upbound/provider-aws/actions/runs/3535890761
aws_config_configuration_aggregator: https://github.com/upbound/provider-aws/actions/runs/3538339476
aws_config_remediation_configuration: https://github.com/upbound/provider-aws/actions/runs/3538408052