Skip to content

Add PathARNExtractor for kms_key_id to rds cluster - #1533

Merged
turkenf merged 2 commits into
crossplane-contrib:mainfrom
turkenf:issue-1523
Oct 22, 2024
Merged

Add PathARNExtractor for kms_key_id to rds cluster#1533
turkenf merged 2 commits into
crossplane-contrib:mainfrom
turkenf:issue-1523

Conversation

@turkenf

@turkenf turkenf commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator

Description of your changes

Adds the PathARNExtractor for kms_key_id to the rds cluster resource

Fixes: #1523

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Tested with uptest (https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11456655642) and manually:

  conditions:
  - lastTransitionTime: "2024-10-22T08:42:00Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced
  - lastTransitionTime: "2024-10-22T08:42:55Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2024-10-22T08:42:53Z"
    reason: Success
    status: "True"
    type: LastAsyncOperation
  - lastTransitionTime: "2024-10-22T08:44:24Z"
    reason: UpToDate
    status: "True"
    type: Test

Signed-off-by: Fatih Türken <turkenf@gmail.com>
Signed-off-by: Fatih Türken <turkenf@gmail.com>
@turkenf

turkenf commented Oct 22, 2024

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/rds/v1beta1/cluster-with-kmskey.yaml"

@turkenf
turkenf marked this pull request as ready for review October 22, 2024 09:13

@erhancagirici erhancagirici left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @turkenf, LGTM

@turkenf
turkenf merged commit 8ef9eff into crossplane-contrib:main Oct 22, 2024
@turkenf
turkenf deleted the issue-1523 branch October 22, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Creating or importing rds-cluster with kms-key supplied by selector fails

2 participants