add custom diff for LBListener forward options - #1528
Conversation
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
65e9b47 to
77d0d73
Compare
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
2bd169a to
1ccb269
Compare
mergenci
left a comment
There was a problem hiding this comment.
Thanks @erhancagirici 🙏 LGTM.
|
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
|
I realized that we should merge this PR after we consume upbound/terraform-provider-aws#276, so I dismissed my approval. |
|
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
Signed-off-by: Cem Mergenci <cmergenci@gmail.com>
5f16395 to
0585e02
Compare
|
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
…al defaulting Signed-off-by: Erhan Cagirici <erhan@upbound.io>
|
/test-examples="examples/elbv2/v1beta1/lblistener.yaml" |
|
To summarize, Uptest failed because of a regression in LBListenerTarget introduced by Terraform provider version bump v5.68.0. The regression caused the resource to enter an update loop: 2024-10-19T22:45:51+03:00 DEBUG provider-aws Diff detected {"uid": "ac9bbe35-e483-4f51-bfea-10fddcc1ddec", "name": "issue-1352-lbtargetgroup", "gvk": "elbv2.aws.upbound.io/v1beta1, Kind=LBTargetGroup", "instanceDiff": "*terraform.InstanceDiff{mu:sync.Mutex{state:0, sema:0x0}, Attributes:map[string]*terraform.ResourceAttrDiff{\"target_health_state.0.unhealthy_draining_interval\":*terraform.ResourceAttrDiff{Old:\"\", New:\"0\", NewComputed:false, NewRemoved:false, NewExtra:interface {}(nil), RequiresNew:false, Sensitive:false, Type:0x0}}, Destroy:false, DestroyDeposed:false, DestroyTainted:false, RawConfig:cty.NilVal, RawState:cty.NilVal, RawPlan:cty.NilVal, Meta:map[string]interface {}(nil)}"}The update loop was present in the Uptest we ran in the version bump PR, but we overlooked it because we only checked whether LBListener panicked, which it did. |
mergenci
left a comment
There was a problem hiding this comment.
Thanks for your weekend operation Erhan 🙂 Now LGTM for real.
|
/test-examples="examples/elbv2/v1beta2/lblistener-forward-single-targetgroup.yaml" |
|
/test-examples="examples/elbv2/v1beta2/lblistener-forward-multiple-targetgroups.yaml" |
bc9f497 to
a8c1fc4
Compare
|
/test-examples="examples/elbv2/v1beta2/lblistener-forward-single-targetgroup.yaml" |
|
/test-examples="examples/elbv2/v1beta2/lblistener-forward-multiple-targetgroups.yaml" |
Signed-off-by: Erhan Cagirici <erhan@upbound.io>
a8c1fc4 to
545d410
Compare
|
added new example manifests to cover forward default action through single target group: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/11436536351/job/31814191141 |
Description of your changes
Fixes the update loop for LBListener.
Will fix #1352
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
manual