Add Bedrock Agent Support - #1503
Merged
Merged
Conversation
Signed-off-by: Blake R <85771645+blakeromano@users.noreply.github.com>
Signed-off-by: Blake R <85771645+blakeromano@users.noreply.github.com>
turkenf
force-pushed
the
bedrock-agent
branch
from
October 11, 2024 12:47
3bc3cf8 to
14c9f26
Compare
Collaborator
|
/test-examples="examples/bedrockagent/v1beta1/agent.yaml" |
Signed-off-by: Fatih Türken <turkenf@gmail.com>
Collaborator
|
/test-examples="examples/bedrockagent/v1beta1/agent.yaml" |
blakeromano
marked this pull request as ready for review
October 11, 2024 14:31
blakeromano
requested review from
mbbush,
sergenyalcin,
turkenf and
ulucinar
as code owners
October 11, 2024 14:31
turkenf
approved these changes
Oct 11, 2024
turkenf
left a comment
turkenf
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks for your efforts on this PR @blakeromano.
I had to rebase your PR and run make generate to be able to include it to today's release.
Contributor
Author
|
Appreciate it @turkenf! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Adds Bedrock Agent
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
make reviewablepasses.I can run
make e2e UPTEST_EXAMPLE_LIST=examples/bedrockagent/v1beta1/agent.yamlwhich does successfully create the resource. I believe hashicorp/terraform-provider-aws#37168 is causing updates to fail which is solved in TF Provider version v5.64.0 which I think will ultimately block this from what I can tell.