feat: add support for Elasticache global replication group - #1485
Conversation
|
/test-examples="examples/elasticache/v1beta1/globalreplicationgroup.yaml" |
turkenf
left a comment
There was a problem hiding this comment.
Thank you for this dedicated PR @apavamontri. I left two small comments.
Could you please squash your commits to make the commit history cleaner?
|
And please sign your commits: https://github.com/crossplane-contrib/provider-upjet-aws/pull/1485/checks?check_run_id=29807125527 |
c4d81fe to
32fbe51
Compare
Rebased and squashed. Thank you for your patient. |
@turkenf, It was my mistake. Add |
Signed-off-by: Anusidh Pavamontri <apavamontri@gmail.com>
32fbe51 to
aa65aec
Compare
|
/test-examples="examples/elasticache/v1beta1/globalreplicationgroup.yaml" |
turkenf
left a comment
There was a problem hiding this comment.
Thanks a lot @apavamontri, LGTM 🙌
Description of your changes
Fixes #1333. Implementing
aws_elasticache_global_replication_groupI have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Running Uptest locally.
Also testing the following cluster setup:
auth_token: reading from Kubernetes secretTimeout need to increase to 1 hour due the at least two clusters creation using
uptest.upbound.io/timeout: "3600"annotation.