Skip to content

feat: add support for Elasticache global replication group - #1485

Merged
turkenf merged 1 commit into
crossplane-contrib:mainfrom
apavamontri:elasticache-global-replication-group
Sep 10, 2024
Merged

feat: add support for Elasticache global replication group#1485
turkenf merged 1 commit into
crossplane-contrib:mainfrom
apavamontri:elasticache-global-replication-group

Conversation

@apavamontri

Copy link
Copy Markdown
Contributor

Description of your changes

Fixes #1333. Implementing aws_elasticache_global_replication_group

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Running Uptest locally.

--- PASS: kuttl (1826.27s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/case (1825.48s)
PASS
15:24:48 [ OK ] running automated tests

Also testing the following cluster setup:

  • auth_token: reading from Kubernetes secret
  • multi-az, failover, number of clusters > 1
  • in-transit encryption

Timeout need to increase to 1 hour due the at least two clusters creation using uptest.upbound.io/timeout: "3600" annotation.

@turkenf

turkenf commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

/test-examples="examples/elasticache/v1beta1/globalreplicationgroup.yaml"

@turkenf turkenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this dedicated PR @apavamontri. I left two small comments.

Could you please squash your commits to make the commit history cleaner?

Comment thread config/externalname.go
Comment thread config/externalnamenottested.go Outdated
@turkenf

turkenf commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

@apavamontri
apavamontri force-pushed the elasticache-global-replication-group branch 2 times, most recently from c4d81fe to 32fbe51 Compare September 10, 2024 17:36
@apavamontri

Copy link
Copy Markdown
Contributor Author

Thank you for this dedicated PR @apavamontri. I left two small comments.

Could you please squash your commits to make the commit history cleaner?

Rebased and squashed. Thank you for your patient.

@apavamontri

Copy link
Copy Markdown
Contributor Author

And please sign your commits: https://github.com/crossplane-contrib/provider-upjet-aws/pull/1485/checks?check_run_id=29807125527

@turkenf, It was my mistake. Add --signoff during rebased and squashed. Thank you for your patience and for helping out during this process

Signed-off-by: Anusidh Pavamontri <apavamontri@gmail.com>
@turkenf
turkenf force-pushed the elasticache-global-replication-group branch from 32fbe51 to aa65aec Compare September 10, 2024 17:55
@turkenf

turkenf commented Sep 10, 2024

Copy link
Copy Markdown
Collaborator

/test-examples="examples/elasticache/v1beta1/globalreplicationgroup.yaml"

https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/10797996747

@turkenf turkenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @apavamontri, LGTM 🙌

@turkenf
turkenf merged commit de2dfa1 into crossplane-contrib:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for Elasticache Global Replication Group resource

2 participants