Skip to content

feat(elasticache): connection details for elasticache (memcached only) #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
turkenf merged 4 commits into from
Aug 6, 2024
Merged

feat(elasticache): connection details for elasticache (memcached only) #1440

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d69fbab
chore: elasticache config
aiell0 Aug 2, 2024
ea56679
chore: change name of example namespace
aiell0 Aug 3, 2024
b8b071c
chore: add comment
aiell0 Aug 3, 2024
79e6dc8
Merge branch 'main' into connection-details-elasticache
aiell0 Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions config/elasticache/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ func Configure(p *config.Provider) { //nolint:gocyclo
r.References["parameter_group_name"] = config.Reference{
TerraformName: "aws_elasticache_parameter_group",
}
r.Sensitive.AdditionalConnectionDetailsFn = func(attr map[string]any) (map[string][]byte, error) {
conn := map[string][]byte{}
// This only works for memcached clusters
if a, ok := attr["cluster_address"].(string); ok {
conn["cluster_address"] = []byte(a)
}
return conn, nil
}
// log_delivery_configuration.destination can point to either
// a CloudWatch Logs LogGroup or Kinesis Data Firehose resource.
delete(r.References, "log_delivery_configuration.destination")
Expand Down
3 changes: 3 additions & 0 deletions examples/elasticache/v1beta1/cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,9 @@ spec:
subnetGroupNameSelector:
matchLabels:
testing.upbound.io/example-name: example
writeConnectionSecretToRef:
name: sample-cluster
namespace: default

---

Expand Down