Skip to content

fix(ec2): launchtemplate late init remove for defaultVersion - #1377

Merged
turkenf merged 1 commit into
mainfrom
fix/ec2-launchtemplate-update-loop
Jun 27, 2024
Merged

fix(ec2): launchtemplate late init remove for defaultVersion #1377
turkenf merged 1 commit into
mainfrom
fix/ec2-launchtemplate-update-loop

Conversation

@haarchri

@haarchri haarchri commented Jun 25, 2024

Copy link
Copy Markdown
Member

Description of your changes

fix update loop issue in ec2 launchtemplate when using spec.forProvider.updateDefaultVersion: true we need to skip late init for defaultVersion otherwise the manifest looks like:

apiVersion: ec2.aws.upbound.io/v1beta1
kind: LaunchTemplate
[...]
spec:
  deletionPolicy: Delete
  forProvider:
[...]
    defaultVersion: 1
[...]
    updateDefaultVersion: true
[...]
status:
  atProvider:
[...]
    defaultVersion: 7
[...]
    latestVersion: 7
[...]
  conditions:
    - lastTransitionTime: "2024-06-05T14:17:20Z"
      reason: Available
      status: "True"
      type: Ready
    - lastTransitionTime: "2024-06-05T17:59:25Z"
      reason: ReconcilePaused
      status: "False"
      type: Synced
    - lastTransitionTime: "2024-06-05T14:17:18Z"
      reason: Success
      status: "True"
      type: LastAsyncOperation

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Uptest run: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/9667399561

…tVersion: true

Signed-off-by: Christopher Haar <christopher.haar@upbound.io>
@haarchri

Copy link
Copy Markdown
Member Author

/test-examples="examples/ec2/v1beta1/launchtemplate.yaml"

@turkenf turkenf left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @haarchri, LGTM.

@turkenf
turkenf merged commit 6bfa63b into main Jun 27, 2024
@sergenyalcin
sergenyalcin deleted the fix/ec2-launchtemplate-update-loop branch February 28, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants