Select spec fields specific to Upbound OIDC - #1265
Conversation
Signed-off-by: Jason Tang <jason@upbound.io>
ulucinar
left a comment
There was a problem hiding this comment.
Thank you @jastang. Discussed this issue with @erhancagirici and we will remove the TokenConfig API from the Upbound authentication scheme once we have the ProviderConfig e2e tests in place.
If, in the future, we would like to be able to configure the source of the OIDC ID token (e.g., making the location of the token configurable so that we may either read it from a local file (as we do right now), or read it from a secret or similar, when the auth method is Upbound), then we can consider re-adding it to the API and implement the retrieval mechanism on top of that API. Currently, the API is there but the retrieval implementation is missing. And in the managed control planes, we always provision the OIDC token on the filesystem at a well-known path, so a configuration for the token source is currently unnecessary.
The alternative would be just to remove the TokenConfig from Upbound auth configuration as the API is dummy and I assume the marketplace does not generate a ProviderConfig with the configuration provided by the TokenConfig API (as it's currently useless). But this is technically a breaking change. And once we have the ProviderConfig e2e tests in place, it will be a better time to make this change in the ProviderConfig.
Description of your changes
Update
auth.yamlto select specific fields in the spec to support Upbound as an identity provider.Screenshot of a deploy with a new xpkg:

Fixes https://github.com/upbound/upbound-frontend/issues/3751
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested