Remove ARN Parameter from Firehose DeliveryStream Resource - #1233
Merged
turkenf merged 1 commit intoApr 18, 2024
Conversation
Signed-off-by: Blake R <85771645+blakeromano@users.noreply.github.com>
blakeromano
requested review from
mbbush,
sergenyalcin,
turkenf and
ulucinar
as code owners
March 22, 2024 02:14
Collaborator
|
/test-examples="examples/firehose/v1beta1/deliverystream.yaml" |
turkenf
approved these changes
Apr 18, 2024
turkenf
left a comment
turkenf
left a comment
Collaborator
There was a problem hiding this comment.
Many thanks for the catch and effort here @blakeromano, LGTM.
FYI: @ulucinar, as we discussed, I can create the resource by setting the arn parameter with Terraform Provider without encountering any problems. In this case, the issue seems to be caused by the underlying provider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This removes the ARN parameter from the Firehose DeliveryStream Resource. After a conversation with @mbbush in this thread https://crossplane.slack.com/archives/C05E0UE46S2/p1711042281273589 this is an attribute we should move to status. I also took some time to optimize the way arn's for other resources were referenced
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Uptest: https://github.com/crossplane-contrib/provider-upjet-aws/actions/runs/8693667532