[Backport release-1.2] Add region parameter back to TF setup.Configuration - #1222
Merged
Conversation
Signed-off-by: Erhan Cagirici <erhan@upbound.io> (cherry picked from commit dde32cd)
github-actions
Bot
requested review from
sergenyalcin,
turkenf and
ulucinar
as code owners
March 17, 2024 02:56
3 tasks
ulucinar
approved these changes
Mar 18, 2024
ulucinar
left a comment
ulucinar
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @erhancagirici, lgtm. Let's open an issue to track implementing the unit tests that assert all the configuration contract expected for the external-name configuration. The idea is if we implement a unit test case that assert the existence of the region key in ps.Configuration, we can catch similar errors in the future. This is something currently missing and we don't want to delay the roll out of this fix.
Collaborator
|
Closing & reopening to retrigger the CI pipelines. |
Collaborator
Collaborator
|
/test-examples="examples/sns/v1beta1/topic.yaml" |
Collaborator
|
/test-examples="examples/kinesis/v1beta1/stream.yaml" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #1221 to
release-1.2.