Decrease linter's memory usage - #1217
Merged
ulucinar merged 2 commits intoMar 18, 2024
Merged
Conversation
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
release-0.47-fix-linter
branch
4 times, most recently
from
March 16, 2024 01:03
7485368 to
20ad5fc
Compare
- Set GOGC to 50% for both lint phases - Set linter runner timeout to 90min Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
release-0.47-fix-linter
branch
2 times, most recently
from
March 18, 2024 15:20
12e1c33 to
cf4d34c
Compare
sergenyalcin
approved these changes
Mar 18, 2024
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
3 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
The linter CI job is currently broken in the actively maintained
release-0.47branch. The PR attempts to get it running again by decreasing its memory footprint. For a detailed analysis and the techniques used in this PR, please see #1194, and for a follow-up discussion, please see #1211.I've reduced the concurrency of both phases to 1, increased the job's timeout to 90m and configured a more aggresive garbage collector by setting the
GOGCto 50 for therelease-0.47branch after a series of experiments, where the parameters we used for themainbranch did not perform well. At some point, we may also need to deploy these more aggressive parameters to themainbranch as there should, currently, not be meaningful difference between the memory requirements of the linter runner between branchesmain&release-0.47, assuming we have not missed to backport any related change from themainbranch. But the linter runner's peak memory consumption is currently on the edge but I suspect this could be a quality-of-service issue with the available hosted runners.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Changes proposed here have been tested on a cold-cache here.