Skip to content

Configure connect group and add examples - #121

Merged
turkenf merged 24 commits into
crossplane-contrib:mainfrom
turkenf:connect-group
Nov 8, 2022
Merged

Configure connect group and add examples#121
turkenf merged 24 commits into
crossplane-contrib:mainfrom
turkenf:connect-group

Conversation

@turkenf

@turkenf turkenf commented Nov 4, 2022 •
edited by turkenh
Loading

Copy link
Copy Markdown
Collaborator

Description of your changes

This PR configures resources in the connect group:

Fixes: #67

Note: I couldn't configure aws_connect_user_hierarchy_group I reported an issue for this: #120

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

make uptest-local EXAMPLE_LIST=examples/connect/botassociation.yaml
make uptest-local EXAMPLE_LIST=examples/connect/contactflow.yaml
make uptest-local EXAMPLE_LIST=examples/connect/contactflowmodule.yaml
make uptest-local EXAMPLE_LIST=examples/connect/hoursofoperation.yaml
make uptest-local EXAMPLE_LIST=examples/connect/instance.yaml
make uptest-local EXAMPLE_LIST=examples/connect/lambdafunctionassociation.yaml
make uptest-local EXAMPLE_LIST=examples/connect/queue.yaml
make uptest-local EXAMPLE_LIST=examples/connect/quickconnect.yaml
make uptest-local EXAMPLE_LIST=examples/connect/routingprofile.yaml
make uptest-local EXAMPLE_LIST=examples/connect/securityprofile.yaml
make uptest-local EXAMPLE_LIST=examples/connect/userhierarchystructure.yaml

@turkenf

turkenf commented Nov 7, 2022

Copy link
Copy Markdown
Collaborator Author

/test-examples="examples/connect/botassociation.yaml,examples/connect/contactflow.yaml,examples/connect/contactflowmodule.yaml,examples/connect/hoursofoperation.yaml,examples/connect/instance.yaml,examples/connect/lambdafunctionassociation.yaml,examples/connect/queue.yaml,examples/connect/quickconnect.yaml,examples/connect/routingprofile.yaml,examples/connect/securityprofile.yaml,examples/connect/userhierarchystructure.yaml"

1 similar comment
@turkenh

turkenh commented Nov 8, 2022

Copy link
Copy Markdown
Contributor

/test-examples="examples/connect/botassociation.yaml,examples/connect/contactflow.yaml,examples/connect/contactflowmodule.yaml,examples/connect/hoursofoperation.yaml,examples/connect/instance.yaml,examples/connect/lambdafunctionassociation.yaml,examples/connect/queue.yaml,examples/connect/quickconnect.yaml,examples/connect/routingprofile.yaml,examples/connect/securityprofile.yaml,examples/connect/userhierarchystructure.yaml"

@turkenh
turkenh requested a review from ezgidemirel November 8, 2022 08:22
ezgidemirel
ezgidemirel reviewed Nov 8, 2022
View reviewed changes

@ezgidemirel ezgidemirel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf for your PR! Added two small comments for adding meta.upbound.io/example-id annotation.

Comment thread examples/connect/lambdafunctionassociation.yaml
Comment thread examples/lambda/function.yaml
ezgidemirel
ezgidemirel approved these changes Nov 8, 2022
View reviewed changes

@ezgidemirel ezgidemirel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf!

turkenf added 19 commits November 8, 2022 15:43
@turkenf
Generate with aws_connect_instance and copy examples from generated
d7bfca3
@turkenf
Fix example for aws_connect_instance
0b2b938
@turkenf
Generate with aws_connect_bot_association and copy examples from gene…
0250ca8 
…rated
@turkenf
Fix external name config and example for aws_connect_bot_association
5336a39
@turkenf
Generate with aws_connect_contact_flow and copy examples from generated
ac261b4
@turkenf
Add reference config and fix example for aws_connect_contact_flow
5ca142d
@turkenf
Generate with aws_connect_contact_flow_module and copy examples from …
94dd73e 
…generated
@turkenf
Add reference config and fix example for aws_connect_contact_flow_module
230a03f
@turkenf
Generate with aws_connect_hours_of_operation and copy examples from g…
ee9c95e 
…enerated
@turkenf
Add reference config and fix example for aws_connect_hours_of_operation
48bf5a4
@turkenf
Generate with aws_connect_lambda_function_association and copy exampl…
2cf03ad 
…es from generated
@turkenf
Fix example for aws_connect_lambda_function_association
cc7c689
@turkenf
Fix example for aws_lambda_function
fc5da61
@turkenf
Generate with aws_connect_queue and copy examples from generated
d200b6f
@turkenf
Add reference config and fix example for aws_connect_queue
d914e92
@turkenf
Generate with aws_connect_quick_connect and copy examples from generated
93fd8e2
@turkenf
Add reference config and fix example for aws_connect_quick_connect
6096121
@turkenf
Generate with aws_connect_routing_profile and copy examples from gene…
d733060 
…rated
@turkenf
Add reference config and fix example for aws_connect_routing_profile
666956a
@turkenf
turkenf merged commit 2075570 into crossplane-contrib:main Nov 8, 2022
@turkenf
turkenf deleted the connect-group branch September 5, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin is a code owner
@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar is a code owner
@turkenh turkenh Awaiting requested review from turkenh
1 more reviewer
@ezgidemirel ezgidemirel ezgidemirel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Moving connect (12) resources to v1beta1 version

3 participants

@turkenf @turkenh @ezgidemirel