Fix the update loop in Firewall.networkfirewall resource - #1167
Merged
Conversation
- Extend the example manifest for the Firewall.networkfirewall resource with some extra parameters and enable the update tests on it. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com> (cherry picked from commit e8b5f1a)
1 task
Collaborator
Author
|
/test-examples="examples/networkfirewall/v1beta1/firewall.yaml" |
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Collaborator
Author
|
/test-examples="examples/networkfirewall/v1beta1/firewall.yaml" |
examples/networkfirewall/v1beta1/firewall.yaml. Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
Collaborator
Author
|
/test-examples="examples/networkfirewall/v1beta1/firewall.yaml" |
sergenyalcin
approved these changes
Feb 27, 2024
sergenyalcin
left a comment
sergenyalcin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @ulucinar LGTM!
Collaborator
Author
|
A local run of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Related PR: upbound/official-providers-ci#180
This PR fixes an update loop issue in the
Firewall.networkfirewallresource and extends the example manifest for the that resource with thefirewallPolicyChangeProtection&subnetChangeProtectionparameters, and enables the update tests on it.This PR also bumps uptest to
v0.11.1to properly run the update test on theFirewall.networkfirewallresource.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Via an uptest run with the update-test step: https://github.com/upbound/provider-aws/actions/runs/8065145812