fix(asg): fix observed failed availability_zones / vpc_zone_identifier - #110
Merged
Merged
Conversation
Signed-off-by: Christopher Paul Haar <christopherpaul.haar@dkb.de>
muvaf
approved these changes
Nov 2, 2022
muvaf
left a comment
muvaf
left a comment
Member
There was a problem hiding this comment.
LGTM! Would it be straight-forward to replace the example with your manifest? It sounds like the YAML you folks are using is more complicated and covers more ground.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Christopher Paul Haar christopherpaul.haar@dkb.de
Description of your changes
we tested today upbound/provider-aws and found one Issue regarding fields in asg availability_zones - looks like this issue has open PRs in crossplane-contrib/provider-jet-aws as well
crossplane-contrib/provider-jet-aws#238
Fixes #106
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested