feat: upgrade provider - #156
Open
fernandezcuesta wants to merge 2 commits into
Open
Conversation
…ailover resource. Refactor external_name and fixed cluster_outage_simulation external name configuration, as well as add a safe fallback to encodedStateGetExternalNameFn Signed-off-by: Jesús Fernández <7312236+fernandezcuesta@users.noreply.github.com>
fernandezcuesta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade upstream Terraform provider to 2.14.0
Configure new
mongodbatlas_stream_connection_failoverresourceRefactor external_name methods to be less redundant (+more explicit) and remove the slice ordering
Add a safe fallback to
encodedStateGetExternalNameFnwhich might poison GetIDFn: whenexternalNameKeywasn't found in decoded state, it returned the full encoded state ID as the external name. This poisoned downstreamGetIDFn(double-encoded garbage in state) andGetImportIDFn(base64 key:value pairs in plain import string). Before, this could lead to the Atlas API receiving base64 fragments instead of real IDs.Fixes: #123