This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Apply tagging convention - #37
Open
sergenyalcin wants to merge 2 commits into
Open
Conversation
sergenyalcin
force-pushed
the
tagging-convention
branch
2 times, most recently
from
January 14, 2022 13:42
9e3e4d6 to
b006097
Compare
sergenyalcin
force-pushed
the
tagging-convention
branch
from
January 26, 2022 21:09
b006097 to
6988a48
Compare
3 tasks
sergenyalcin
marked this pull request as ready for review
January 26, 2022 21:20
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
tagging-convention
branch
from
January 27, 2022 14:45
6988a48 to
7e1ca56
Compare
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
tagging-convention
branch
from
January 28, 2022 15:12
0488801 to
4f10c4e
Compare
muvaf
approved these changes
Apr 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR adds tagging convention for provider-gcp.
This PR depends on crossplane/terrajet#198
Until merge the dependent PR, a temporary replace command was added to go.mod:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Some example manifests were applied. Then tags of MRs and external resources were checked.