This repository was archived by the owner on May 30, 2025. It is now read-only.
Add support for Secrets Manager - #317
Draft
RealHarshThakur wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
Signed-off-by: Harsh Thakur <harshthakur9030@gmail.com>
Member
|
Can we merge this and #305 into one PR? Do we need both open? |
Contributor
Author
|
@negz Initially, had them as one. Later, split out to make it easier to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
This is continuation of this PR #305 .
It aims to add Kubernetes Secret Reference
I have:
make reviewable testto ensure this PR is ready for review.Slack thread:
How has this code been tested