This repository was archived by the owner on May 22, 2025. It is now read-only.
Support configurable reconcile rates - #312
Draft
negz wants to merge 5 commits into
Draft
Conversation
Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
Partially addresses crossplane/crossplane#2595 Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
Signed-off-by: Nic Cope <negz@rk0n.org>
negz
marked this pull request as draft
December 3, 2021 02:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Partially addresses crossplane/crossplane#2595 - see that issue for details.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
I've tested a similar change to provider-gcp together with crossplane/crossplane#2602. See crossplane/crossplane#2568 (comment) for details.
I still need to test this specifically, especially the places where I've removed the operation polling in favour of a creation grace period.