Add Application, ServicePrincipal, Role, Group, RoleAssignment support - #297
Add Application, ServicePrincipal, Role, Group, RoleAssignment support#297vaspahomov wants to merge 3 commits into
Conversation
e109a80 to
07e20dc
Compare
ulucinar
left a comment
There was a problem hiding this comment.
Hi @vaspahomov,
Thank you for the PR. I have left some comments. Could you please also mention in the PR description how you tested these new MRs?
| } | ||
|
|
||
| const ( | ||
| appCredsValidYears = 5 |
There was a problem hiding this comment.
Should we make this part of the spec (i.e., make it a parameter)?
There was a problem hiding this comment.
I think better to implement creds autoupdates, I added todo note about this
d996d20 to
0f1a5c5
Compare
Signed-off-by: vaspahomov <vas2142553@gmail.com>
0f1a5c5 to
0288a64
Compare
|
Hi! @ulucinar |
|
Any updates when this PR is getting merged? |
|
Hi @vaspahomov, |
Signed-off-by: vaspahomov <vas2142553@gmail.com>
|
Hi @ulucinar, |
Thank you very much @vaspahomov for bearing with us on this PR. Together with @sergenyalcin, we took another pass over the PR. Among the resolved issues, I did not fully understand the logic here: Could you please shed some light on these probably with comments? |
|
Do I understand correctly that this change uses the Active Directory Graph API for communication with Azure? If that is the case it should be noted that those API:s are deprecated and support will be removed on June 30th, 2022. |
|
we are in need of this |
Description of your changes
Add support of:
This patch allow:
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested