fix(repositories): Support project scoping for Observe, Delete in Repository resources - #335
Merged
MisterMX merged 1 commit intoSep 23, 2025
Conversation
Signed-off-by: Rounak Datta <rounak@lyric.tech>
rounakdatta
force-pushed
the
repository-project-scoping
branch
from
September 15, 2025 13:52
9bb78a9 to
2cbc0e8
Compare
MisterMX
changed the title
MisterMX
changed the title
MisterMX
approved these changes
Sep 23, 2025
MisterMX
left a comment
MisterMX
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thank you very much @rounakdatta!
|
Successfully created backport PR #338 for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
For Repositories, there's a wierd behaviour that when you pass a Project in the XRD, the Argo repository gets created, but it goes into an unhealthy state right after that. This happens because I think there's a bug in the Repository controller code. In the Observe function, we don't pass the project to the
RepoQueryexplicitly, and therefore it fails with an obvious errorobserve failed: rpc error: code = Unknown desc = repository not found for url "https://github.com/my-org/hello-world.git" and project "". I've added the param and added a test case to validate.Fixes #245
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested