Fix array parameter handling in tool declarations for Gemini and OpenAI #358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gemini API requires an 'items' field for array-type parameters
in tool declarations to specify the type of array elements. Without
this field, the API returns errors like:
"GenerateContentRequest.tools[0].function_declarations[2].parameters.properties[fields].items: missing field"
This fix adds the required 'items: { type: 'STRING' }' field for
all array parameters when formatting tools for the Gemini provider.
Changes:
- Modified format_parameters method to add items field for array types
- Added comprehensive unit tests for the fix
- Added integration tests to verify proper tool formatting
This resolves issues when using tools with array parameters in
Gemini models, enabling proper function calling with arrays.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
Removed duplicate test coverage by consolidating tools_array_parameter_handling_spec.rb into tools_spec.rb. The single test file now comprehensively covers: - Array parameters with items field - Mixed parameter types - Required vs optional parameters - Integration test of format_tools method
Similar to the Gemini fix, OpenAI also requires an 'items' field
for array-type parameters in tool/function declarations. Without
this field, tools with array parameters may not work correctly.
This commit adds the required 'items: { type: 'string' }' field
for all array-type parameters when formatting tools for OpenAI.
Changes:
- Modified param_schema method to add items field for array types
- Added comprehensive tests for array parameter handling
- Tests verify both single and multiple array parameters work correctly
finbarr
changed the title
crmne
requested changes
Aug 29, 2025
| type: param_type_for_gemini(param.type), | ||
| description: param.description | ||
| }.compact | ||
|
|
||
| # Add items field for array types | ||
| property[:items] = { type: 'STRING' } if param.type.to_s.downcase == 'array' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
itemsfield for array parameters in tool declarationsGenerateContentRequest.tools[0].function_declarations[2].parameters.properties[fields].items: missing fieldProblem
Both Gemini and OpenAI APIs require an
itemsfield for array-type parameters in tool/function declarations to specify the type of array elements. Without this field, tools with array parameters fail with missing field errors or may not work correctly.Solution
Modified the parameter formatting methods in both providers to automatically add the
itemsfield for all array-type parameters:items: { type: 'STRING' }informat_parametersmethoditems: { type: 'string' }inparam_schemamethodChanges
lib/ruby_llm/providers/gemini/tools.rbto add items field for array typeslib/ruby_llm/providers/openai/tools.rbto add items field for array typesspec/ruby_llm/providers/gemini/tools_spec.rbspec/ruby_llm/providers/openai/tools_spec.rbTest Plan
This resolves issues when using tools with array parameters in both Gemini and OpenAI models, enabling proper function calling with arrays across multiple providers.
🤖 Generated with Claude Code