Check Nomad group meta tags#763
Merged
crazy-max merged 1 commit intocrazy-max:masterfrom Jan 14, 2023
Merged
Conversation
crazy-max
reviewed
Jan 11, 2023
crazy-max
reviewed
Jan 11, 2023
Owner
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Can you squash your commits?
Contributor
Author
|
I think there's also an option to "Squash and Merge" in GitHub though if you wanted to do that. Would you like me to squash on my branch anyway? |
Owner
Yes please, I switched to merge commit on this repo to keep relevant commits when there are multiple on some PRs. |
This was intended originally and included in the documentation, but missed in the implementation.
IamTheFij
force-pushed
the
nomad-group-meta
branch
from
8861b9c to
e7051f2
Compare
Contributor
Author
|
Squashed. I thought that you could still hit the down arrow next to the merge button and chose a new option per PR, but I haven't played with it very much. |
crazy-max
approved these changes
Jan 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was intended originally and included in the documentation, but missed in the implementation.