Skip to content

Correct the issues URL#697

Merged
crazy-max merged 1 commit intocrazy-max:masterfrom
DougEdey:patch-1
Oct 7, 2022
Merged

Correct the issues URL#697
crazy-max merged 1 commit intocrazy-max:masterfrom
DougEdey:patch-1

Conversation

@DougEdey
Copy link
Contributor

@DougEdey DougEdey commented Oct 7, 2022

The repo_url does not contain a trailing slash, so the link is a 404, and with the q= query in the URL it searches all Issues & PRs which is not what I think is wanted.

Current URL: https://github.com/crazy-max/diunissues?utf8=%E2%9C%93&q=
New URL: https://github.com/crazy-max/diun/issues?utf8=%E2%9C%93

The repo_url does not contain a trailing slash, so the link is a 404, and with the `q=` query in the URL it searches all Issues & PRs which is not what I think is wanted.
@DougEdey DougEdey requested a review from crazy-max as a code owner October 7, 2022 18:36
Copy link
Owner

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 2db20dd into crazy-max:master Oct 7, 2022
@DougEdey DougEdey deleted the patch-1 branch October 8, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants