fix: Use global defaults in File provider#1063
Merged
crazy-max merged 1 commit intocrazy-max:masterfrom Dec 30, 2023
adamantike:fix/use-defaults-in-file-provider
Merged
fix: Use global defaults in File provider#1063crazy-max merged 1 commit intocrazy-max:masterfrom adamantike:fix/use-defaults-in-file-provider
crazy-max merged 1 commit intocrazy-max:masterfrom
adamantike:fix/use-defaults-in-file-provider
Conversation
The `file` provider was not considering the global defaults for `MaxTags`, `IncludeTags`, and `ExcludeTags`. Updated unit tests to validate they are now considered.
Contributor
Author
|
@crazy-max Are you planning to create a new release to make this change available? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fileprovider was not considering the global defaults forMaxTags,IncludeTags, andExcludeTags.Updated unit tests to validate they are now considered.