Over-haul of CI #166
Over-haul of CI #166
Conversation
The objective of the project is to be able to do SQL stuff without a CrateDB instance, so it does not make any sense to have one.
Removed 3.8 which reached EOL and ignored 3.9 which reaches it soon. https://devguide.python.org/versions/
* Use uv in pipelines * Add path for more fine-controlled executions fixes crate#39 * Change parent project to uv * Update metadata
| release_javascript: | ||
| uses: ./.github/workflows/release_javascript.yml | ||
| release_python: | ||
| uses: ./.github/workflows/release_python.yml |
| urls.changelog = "https://github.com/crate/cratedb-sqlparse/blob/main/CHANGES.md" | ||
| urls.documentation = "https://github.com/crate/cratedb-sqlparse" | ||
| urls.homepage = "https://github.com/crate/cratedb-sqlparse" | ||
| urls.repository = "https://github.com/crate/cratedb-sqlparse" | ||
|
|
||
| [project.urls] | ||
| Homepage = "https://github.com/crate/cratedb-sqlparse" | ||
| Documentation = "https://github.com/crate/cratedb-sqlparse" | ||
| Repository = "https://github.com/crate/cratedb-sqlparse" | ||
| Changelog = "https://github.com/crate/cratedb-sqlparse/releases" |
There was a problem hiding this comment.
Is this section compatible with the convention pyproject-fmt proposes?
poe format doesn't do it differently?
There was a problem hiding this comment.
I'd say so, I was actually getting errors when testing/building in python 3.14 if I recall and changing it this way fixed it, this is afaik the pep621 way of doing it, https://packaging.python.org/en/latest/specifications/well-known-project-urls/ so if pyproject-fmt complained (by not following the spec) I'd ditch it
There was a problem hiding this comment.
pyproject-fmt is not complaining. It just applies formatting conventions and is not violating PEP621 at all, it just applies a different formatting. I'd not ditch it, because it provides a canonical form for the project metadata file, with the same benefit for collaborative development like the other code formatters are providing it.
There was a problem hiding this comment.
it was a conditional statement
There was a problem hiding this comment.
Hi again. This patch explains better what I was referring to.
| python -m pip install build twine | ||
| cd cratedb_sqlparse_py | ||
| python -m build | ||
| twine check dist/{*.tar.gz,*.whl} |
There was a problem hiding this comment.
If you like it, a variant of those incantations could be:
cd cratedb_sqlparse_py
python -m pip install '.[release]'
poe releasecratedb-sqlparse/cratedb_sqlparse_py/pyproject.toml
Lines 87 to 90 in 6542f48
cratedb-sqlparse/cratedb_sqlparse_py/pyproject.toml
Lines 221 to 224 in 6542f48
In this spirit, CI and manual procedures will be synchronized, through the canonical poe release command.
Lines 109 to 113 in 6542f48
For a long time I was unhappy with how the setup of this project ended up being, it was prone to breaking and made maintenance annoying. I've simplified and improve things to address these issues:
Summary of the changes / Why this is an improvement
Checklist